-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: update project listing depending on the dev mode #442
Open
enesozturk
wants to merge
3
commits into
main
Choose a base branch
from
refactor/dev-badge-and-dev-mode-project-listing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
enesozturk
force-pushed
the
refactor/dev-badge-and-dev-mode-project-listing
branch
from
February 20, 2024 11:03
423ac40
to
25fd38e
Compare
Sorry I didn't explain this very well, I wanted something different. See Slack conversation |
chris13524
approved these changes
Feb 20, 2024
chris13524
reviewed
Feb 20, 2024
@@ -61,7 +68,7 @@ const useNotifyProjects = () => { | |||
} | |||
|
|||
fetchNotifyProjects() | |||
}, [setProjects, filterAppDomain]) | |||
}, [isDevModeEnabled, setProjects, filterAppDomain]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be reverted?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor the dev badge on the app card and project listings depending on the developer mode status.
Type of change
Fixes/Resolves (Optional)
Closes #441
Closes #440
Checklist:
Additional Information (Optional)
Slack conv