-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix lava crystal and primitive fuel cell in ARC #2015
Open
stellanera98
wants to merge
105
commits into
WayofTime:1.18.2
Choose a base branch
from
stellanera98:1.18.2-arc-furnace
base: 1.18.2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
May eventually change so that formatting is consistent across all users of the project. For now, we can squabble about code styles to our hearts' content.
fix Hellforged Record jukebox interaction
added "active inventories" to API changed divination HUD element to check active inventories added divination/seer sigil to curio slot tags changed divination HUD element shouldRender() to only return true when the correct sigil is held or the tile looked at is a TileIncenseAltar
Make Curio and Elytra-render Item checks generalized
…-hud fixing seer sigil duplicate altar HUD
fixes the server launching
Required changes to the Global Loot Modifier. Best to keep an eye on https://docs.minecraftforge.net/en/1.20.x/resources/server/glm/ if it occurs again. Fixes WayofTime#1974
Curios Slot info is now Data Generated. Bumped Curios version in Gradle Properties. The Socket Upgrade's slot adding/removing features is still very much work-in-progress.
Update the Sanguine Scientiem's Creative Tab setting. This makes it appear in the proper spot in the Creative Menu, and makes it show up in JEI again.
These (currently unused) models were throwing "Invalid Resource Location" errors in the log. Adjusted them to the new naming scheme where possible. I was unable to find the new asset location for the Routing Node models. I suspect they have already been replaced and those models can be removed.
Adds a ModID Check to Meteor Recipes. The "modid" field is optional and will use our ID if not specified, which is obviously loaded. Not loaded ModIDs return null, which skips that recipe. This is a single line in the log rather than a large stacktrace. Added ModIDs (copied from the 1.16 guidebook documentation) to the 5 mod-compat meteors.
This reverts commit e2c64ef.
The proper way to make recipes depend on another mod being installed.
Update Guidebook's Creative Tab (fixes it missing in JEI)
These have either already been replaced, or are known to not be coming back.
Bump Curios to the latest available 1.20.1 version. Transient modifiers seem to handle relogs better, but is still very buggy.
Lower Contrast to match the current Curios default slot style.
Removed Some Log Spam
…tion Update Curios Implementation (1.20 API)
Made the Routing Node Amount Textbox selectable again. Fixes WayofTime#1980 Made the Text Box only selectable if a Ghost Filter Slot has been clicked. Prevents players from typing in a value for nothing. Added a Right-Click function to the text box. This will clear it, set the ghost item value back to 0 ("Everything"), and select the Text Box for a new number.
Fix and Upgrade Routing Node Amount Text Box
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2014 and #1921
Changed craftFurnace to allow tool breaking
Changed consumeInventory to pass toolStack instead of inputStack to toolStack.getItem().getContainerItem()