Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make HarvestRegistry available from API and fix Mystical Agriculture crops with harvest ritual #2020

Open
wants to merge 1 commit into
base: 1.20.1
Choose a base branch
from

Conversation

stellanera98
Copy link
Contributor

  • Added getHarvestRegistry() to IBloodMagicAPI and BloodMagicAPI
  • Modified HarvestRegistry to not be static to make it consistent with other API things
  • Moved the registration calls from ritual/ModRituals to impl/BloodMagicCorePlugin
  • Removed compat with mods not in 1.20 and Pams HarvestCraft as I couldnt find a 1.20 version of the repo/api
  • Added compat/MysticalAgricultureCompat, when its loaded it registers their crops. Uses the actual mag api jar instead of Class.forName() and such
  • Added repository/dependencies for Mystical Agriculture (commented out the runtime stuff)
  • Added version variables for mag and the needed cucumber library in gradle.properties

(Changed my setup again, auto-formatting doesnt seem to work all the time, hope i caught at least most of it)

@VT-14 VT-14 added the 1.20 label Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants