Skip to content
This repository has been archived by the owner on Jan 15, 2025. It is now read-only.

Test largest valid initial size for table32 and table64 in table.wast #104

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

evicy
Copy link
Contributor

@evicy evicy commented Nov 13, 2024

No description provided.

@bvisness
Copy link
Collaborator

bvisness commented Nov 13, 2024

Actually attempting to allocate an i64 table with (at minimum) 18 exabytes of data is probably not a good idea. Even actually allocating 4GB i32 tables in tests is pretty likely to fail.

It's fine to ensure that these table limits are valid, but we shouldn't actually instantiate tables with the maximum possible initial size.

@backes
Copy link
Member

backes commented Nov 14, 2024

It's fine to ensure that these table limits are valid, but we shouldn't actually instantiate tables with the maximum possible initial size.

Agreed; according to the JS embedding limits those modules are expected to fail instantiation, but that's something to test in the "limits" test in the js tests.
The new form (using module definition) looks good to me.

@bvisness bvisness merged commit 0c1cecc into WebAssembly:main Nov 14, 2024
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants