Respect CC/CXX/CFLAGS/CXXFLAGS/LDFLAGS. #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Piotr Sikora <[email protected]>
|
cc @rossberg |
PiotrSikora
commented
May 17, 2019
|
|
||
| # Linking C / C++ example | ||
| .PRECIOUS: ${EXAMPLES:%=${EXAMPLE_OUT}/%-c} | ||
| ${EXAMPLE_OUT}/%-c: ${EXAMPLE_OUT}/%-c.o ${WASM_C_O} | ||
| ${CC_COMP} ${C_FLAGS} ${LD_FLAGS} $< -o $@ \ | ||
| ${CXX} ${CXXFLAGS} ${LDFLAGS} $< -o $@ \ |
There was a problem hiding this comment.
Note: I changed CFLAGS to CXXFLAGS here, since CXX is used to link those targets, so it seemed more correct.
|
Ping. |
rossberg
reviewed
Jun 19, 2019
There was a problem hiding this comment.
To be honest, I'm not a big fan of inheriting configuration flags from the environment, since they are easily clobbered by accident that way (dynamic scoping sucks!). Do you have a use case where it is not enough to set them from the command line (make VAR=X instead of VAR=X make)?
|
|
||
| C_COMP = clang | ||
| ifeq ($(origin CC),default) | ||
| CC = clang |
| CC = clang | ||
| endif | ||
| ifeq ($(origin CXX),default) | ||
| CXX = clang++ |
There was a problem hiding this comment.
Same here.
Of course, moving this here loses the ability to set both compilers with just one command line var.
|
|
||
| # Linking C / C++ example | ||
| .PRECIOUS: ${EXAMPLES:%=${EXAMPLE_OUT}/%-c} | ||
| ${EXAMPLE_OUT}/%-c: ${EXAMPLE_OUT}/%-c.o ${WASM_C_O} | ||
| ${CC_COMP} ${C_FLAGS} ${LD_FLAGS} $< -o $@ \ | ||
| ${CXX} ${CXXFLAGS} ${LDFLAGS} $< -o $@ \ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Piotr Sikora [email protected]