Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test: Attachment with symbols in filename #436

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nuernbergerA
Copy link
Contributor

Hey its me again with an attachment name issue.

If added a failing test, happy fixing.

greetings
Adrian

@nuernbergerA
Copy link
Contributor Author

There was 1 failure:

1) Tests\issues\Issue410Test::testIssueEmailSymbols
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'Checkliste 10.,DAVIDGASSE 76-80;2;2.pdf'
+'Checkliste 10.,DAVIDGASSE 76-80'

/home/runner/work/php-imap/php-imap/tests/issues/Issue410Test.php:62

@Webklex
Copy link
Owner

Webklex commented Sep 14, 2023

Hi @nuernbergerA ,
many thanks for your pull request and bug report. Please try to add name and filename to the list of excluded attributes in https://github.com/Webklex/php-imap/blob/master/src/Header.php#L615 and see if this solves the issue.

@Webklex Webklex added the bug Something isn't working label Sep 14, 2023
@nuernbergerA
Copy link
Contributor Author

@Webklex nope still the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants