Fix #13638: Utilize {% querystring %} template tag for pagination #13910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
nijel
reviewed
Feb 18, 2025
| <li> | ||
| <a href="?{% querystring page=page_obj.next_page_number %}">Next »</a> | ||
| </li> | ||
| {% endif %} |
There was a problem hiding this comment.
Can you please bring back the original markup?
- Page navigation is missing
- UI icons are no longer used
- RTL languages are no longer getting correct icons
- Strings are no longer localized
| data["checksum"] = "" | ||
| self.data = data | ||
| return self | ||
| # def items(self): |
There was a problem hiding this comment.
If the code is no longer used, just remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses issue #13638 by simplifying the querystring handling logic for pagination in
weblate.trans.forms.SearchForm. The complex logic has been replaced by using the{% querystring %}template tag introduced in Django 5.1.Changes Made
items,urlencode, andreset_offsetmethods inSearchForminweblate/trans/forms.py.weblate/templates/paginator.htmlto use the{% querystring %}template tag.weblate/templates/search.htmlinclude the updatedpaginator.html.Testing
Additional Context
This change leverages the new
{% querystring %}template tag introduced in Django 5.1, which simplifies the querystring handling logic and improves maintainability.Checklist
Screenshots (if applicable)
N/A
Related Issues