-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Webhooks #14009
base: main
Are you sure you want to change the base?
feat: Webhooks #14009
Conversation
gersona
commented
Feb 25, 2025
- fixes Web Hooks #7604
@nijel before continuing, I'd like to have your input on a few points: iconIs it beneficial to add a new icon just for the webhooks add-on ? If so, I thought of something like the following, but am not sure if there's a repository we can get them from delivery failures and retriesTo simplify things, I used celery tasks for the message delivery , which handles retries on failure. PayloadI more or less replicated what was included in the Fedora messaging payload. Is there something special to be added or removed ? Payload signaturethe standard-webhooks guidelines encourage to sign the payload, do we also need to provide a way to verify that signature in the code (a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I've addressed most of the questions inline, the only remaining bit is signature. We need an implementation for verification anyway for testing this in the testsuite. Maybe there is some standard function we can use here instead of reimplementing it?