Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Webhooks #14009

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

feat: Webhooks #14009

wants to merge 4 commits into from

Conversation

gersona
Copy link
Contributor

@gersona gersona commented Feb 25, 2025

@gersona
Copy link
Contributor Author

gersona commented Feb 25, 2025

@nijel before continuing, I'd like to have your input on a few points:

icon

Is it beneficial to add a new icon just for the webhooks add-on ? If so, I thought of something like the following, but am not sure if there's a repository we can get them from
https://icons8.com/icons/set/webhook--nocorrect

delivery failures and retries

To simplify things, I used celery tasks for the message delivery , which handles retries on failure.
Does it seem OK to your or do we need a way to track delivery status for each webhook event (which might require having a new model).

Payload

I more or less replicated what was included in the Fedora messaging payload. Is there something special to be added or removed ?

Payload signature

the standard-webhooks guidelines encourage to sign the payload, do we also need to provide a way to verify that signature in the code (a verify method that users can use), or should it just be explained in the documentation ?

Copy link
Member

@nijel nijel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I've addressed most of the questions inline, the only remaining bit is signature. We need an implementation for verification anyway for testing this in the testsuite. Maybe there is some standard function we can use here instead of reimplementing it?

@nijel nijel added this to the 5.11 milestone Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web Hooks
2 participants