Add Django 5.1 support, are updated fetch_points_of_sales, blocked field of PointOfSale & signals #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eld of PointOfSale & signals
WhyNotHugo
requested changes
Aug 13, 2024
Comment on lines
+19
to
+23
| migrations.AlterField( | ||
| model_name='taxpayer', | ||
| name='logo', | ||
| field=models.ImageField(blank=True, help_text='A logo to use when generating printable receipts.', null=True, upload_to='afip/taxpayers/logos/', verbose_name='logo'), | ||
| ), |
There was a problem hiding this comment.
Qué cambio hubo en este campo?
There was a problem hiding this comment.
No nada, al hacer makemigrations me salía el archivo de migración del campo logo y lo había puesto junto al de la alteración del campo bloqueado, me olvidé de separar eso. Y me olvidé de verificar si hace falta ese archivo de migración del campo logo o solo es un error mío.
|
El error con Python 3.8 no está relacionado a tus cambios y podés ignorarlo: #222 |
pull from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fetch_points_of_sales, los objetosPointOfSalessolo se actualizan si sus campos han cambiado, en la primera llamada afetch_points_of_sales, no se creanPointOfSalessi estos vienen bloqueados.blockedcon un valor predeterminado deFalseen el modeloPointOfSales._get_storage_from_settingsya que en versionesDjango >= 4.2ya no se utilizaDEFAULT_FILE_STORAGE.certificateylogoenTaxPayer.