-
-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README.md: Add Quick install section #1194
base: master
Are you sure you want to change the base?
Conversation
Lgtm, but maybe should include instructions to install it in /usr/local/bin? That way it's in $PATH and doesn't require invoking with sh /full/path |
Honestly the quick install script should be just: sudo curl -o /usr/local/bin/winetricks https://raw.githubusercontent.com/Winetricks/winetricks/master/src/winetricks
sudo chmod +x /usr/local/bin/winetricks And the full install: sudo curl --create-dirs -o /usr/local/bin/winetricks https://raw.githubusercontent.com/Winetricks/winetricks/master/src/winetricks
sudo chmod +x /usr/local/bin/winetricks
sudo curl --create-dirs -o /usr/local/share/man/man1/winetricks.1 https://raw.githubusercontent.com/Winetricks/winetricks/master/src/winetricks.1
sudo curl --create-dirs -o /usr/local/share/applications/winetricks.desktop https://raw.githubusercontent.com/Winetricks/winetricks/master/src/winetricks.desktop
sudo curl --create-dirs -o /usr/local/share/metainfo/winetricks.appdata.xml https://raw.githubusercontent.com/Winetricks/winetricks/master/src/winetricks.appdata.xml
sudo curl --create-dirs -o /usr/local/share/icons/hicolor/scalable/apps/winetricks.svg https://raw.githubusercontent.com/Winetricks/winetricks/master/src/winetricks.svg
sudo curl --create-dirs -o /usr/local/share/bash-completion/completions/winetricks https://raw.githubusercontent.com/Winetricks/winetricks/master/src/winetricks.bash-completion Much simpler and more complete than the old instructions. However, curl seems to be creating the directories with Actually, even better, add a
The
Let's make that option known! :) |
|
||
You can then run it from a terminal with | ||
~~~~~ | ||
sh winetricks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will not advise it like this. I would first use chmod and just execute script as intended..
sh winetricks | |
# Make executable | |
chmod +x ./winetricks | |
# Run | |
./winetricks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See new comment below. But thanks @melroy89
1cbeb16
to
ce23f30
Compare
I tried to keep the instructions as easy as possible. My intended use case is for an ad-hoc usage (Personally I use the packaged Winetricks, and only if this has issues I grab a current version for one-time usage.)
The suggestions for just throwing it in /usr/local/bin/ and making it executable are fine. But my point is to do it either right (packaged version or scripted install) or go with the quickest solution. /usr/local/bin is somewhere in the middle, I wouldn't do that. In the end my main point is to get rid of some Debian bashing and other noise in the README. |
ce23f30
to
7595404
Compare
7595404
to
20cad4c
Compare
Updated and added "-O winetricks" to overwrite a previously downloaded winetricks. Otherwise the new one would get a suffix and the user would execute the old one. I'm open to both changing this to /usr/local/bin/ and/or chmod +x. Above is just my reasoning for doing it otherwise, but each solution qualifies as a "Quick install", so I have no hard opinion on this. |
For #1192.