Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md: Add Quick install section #1194

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jre-wine
Copy link
Contributor

For #1192.

@austin987
Copy link
Contributor

Lgtm, but maybe should include instructions to install it in /usr/local/bin? That way it's in $PATH and doesn't require invoking with sh /full/path

@qwertychouskie
Copy link
Contributor

Honestly the quick install script should be just:

sudo curl -o /usr/local/bin/winetricks https://raw.githubusercontent.com/Winetricks/winetricks/master/src/winetricks
sudo chmod +x /usr/local/bin/winetricks

And the full install:

sudo curl --create-dirs -o /usr/local/bin/winetricks https://raw.githubusercontent.com/Winetricks/winetricks/master/src/winetricks
sudo chmod +x /usr/local/bin/winetricks
sudo curl --create-dirs -o /usr/local/share/man/man1/winetricks.1 https://raw.githubusercontent.com/Winetricks/winetricks/master/src/winetricks.1
sudo curl --create-dirs -o /usr/local/share/applications/winetricks.desktop https://raw.githubusercontent.com/Winetricks/winetricks/master/src/winetricks.desktop
sudo curl --create-dirs -o /usr/local/share/metainfo/winetricks.appdata.xml https://raw.githubusercontent.com/Winetricks/winetricks/master/src/winetricks.appdata.xml
sudo curl --create-dirs -o /usr/local/share/icons/hicolor/scalable/apps/winetricks.svg https://raw.githubusercontent.com/Winetricks/winetricks/master/src/winetricks.svg
sudo curl --create-dirs -o /usr/local/share/bash-completion/completions/winetricks https://raw.githubusercontent.com/Winetricks/winetricks/master/src/winetricks.bash-completion

Much simpler and more complete than the old instructions. However, curl seems to be creating the directories with drwxr-x--- as the permissions (no read for standard users), maybe one of you knows a way around this that won't complicate things a bunch.

Actually, even better, add a --self-install option to Winetricks, then the entire install would be:

wget -qO - https://github.com/Winetricks/winetricks/raw/master/src/winetricks | pkexec sh /dev/stdin --self-install

The --self-install function would mkdir -p the necessary directories, then download the files to their locations as above. self-install would default to /usr/local as the prefix, while e.g. self-install=/usr would use /usr as the prefix.

qwerty@qwerty-Inspiron-3520:~$ wget -qO - https://github.com/Winetricks/winetricks/raw/master/src/winetricks | pkexec sh /dev/stdin --self-install
------------------------------------------------------
unknown option --self-install
------------------------------------------------------
qwerty@qwerty-Inspiron-3520:~$ 

Let's make that option known! :)


You can then run it from a terminal with
~~~~~
sh winetricks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will not advise it like this. I would first use chmod and just execute script as intended..

Suggested change
sh winetricks
# Make executable
chmod +x ./winetricks
# Run
./winetricks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See new comment below. But thanks @melroy89

@jre-wine
Copy link
Contributor Author

I tried to keep the instructions as easy as possible. My intended use case is for an ad-hoc usage (Personally I use the packaged Winetricks, and only if this has issues I grab a current version for one-time usage.)

  • no sudo is needed for putting it in /usr/local/bin
  • no chmod (wouldn't hurt, but I want to use it just once)

The suggestions for just throwing it in /usr/local/bin/ and making it executable are fine. But my point is to do it either right (packaged version or scripted install) or go with the quickest solution. /usr/local/bin is somewhere in the middle, I wouldn't do that.

In the end my main point is to get rid of some Debian bashing and other noise in the README.

README.md Outdated Show resolved Hide resolved
@jre-wine
Copy link
Contributor Author

Updated and added "-O winetricks" to overwrite a previously downloaded winetricks. Otherwise the new one would get a suffix and the user would execute the old one.

I'm open to both changing this to /usr/local/bin/ and/or chmod +x. Above is just my reasoning for doing it otherwise, but each solution qualifies as a "Quick install", so I have no hard opinion on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants