Refactored link checks #2204
Open
Refactored link checks #2204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Check w_download_to - Check only URL, not whole line - Find lines that don't start with w_download - Allow escaped $ in URL - Escape '\$' to '%24'
austin987
reviewed
Sep 19, 2024
src/linkcheck.sh
Outdated
| @@ -1,4 +1,6 @@ | |||
| #!/bin/sh | |||
| # shellcheck disable=SC2317 | |||
There was a problem hiding this comment.
Please keep it local to the affected functions instead of making it global.
There was a problem hiding this comment.
Done. It was global, as it applies to multiple lines.. but this should be fine now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some issues with the link checker.
The commit 2bc95a1 is reverted, but I can't find a reason why it should be a problem. Feedback is appreciated.
CC #2199