Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support enum #16

Merged
merged 2 commits into from
Aug 5, 2022
Merged

feat: Support enum #16

merged 2 commits into from
Aug 5, 2022

Conversation

kgtkr
Copy link
Contributor

@kgtkr kgtkr commented Aug 5, 2022

I was looking for such a great library because I was in trouble with some problems of envy and config-rs. Thanks.
I wanted enum support, so I implemented it.
See the test for details on how it works.

Unfortunately, in non-self-describing formats, Externally tagged
can only support.
see: serde-rs/serde#2187


It might be nice to have an option to specify the variant name (like _TYPE)

src/de.rs Outdated Show resolved Hide resolved
@Xuanwo Xuanwo changed the title Support enum feat: Support enum Aug 5, 2022
@kgtkr kgtkr requested a review from Xuanwo August 5, 2022 12:24
Copy link
Owner

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR!

@Xuanwo Xuanwo merged commit 0aa7a14 into Xuanwo:main Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants