[refactor] Move Success, Info Dialog to Interrupt Category #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Yejin0O0
approved these changes
Jan 15, 2025
Yejin0O0
approved these changes
Jan 15, 2025
| // } | ||
| // }; | ||
|
|
||
| const findFilesRecursively = async (dir: string, ext = "Base.tsx") => { |
There was a problem hiding this comment.
It means file 'ext'ension... Do you think it needs to change the naming?
| console.log(`Generated: ${outputFilePath}`); | ||
| } | ||
| // Remove files in the output directory | ||
| await fs.remove(outputDir); |
There was a problem hiding this comment.
If don't remove the file, is error occurred?
There was a problem hiding this comment.
Unnecessary(ex. CheckBoxFormBaseString, RadioBoxRowFormBaseString) files still remained in the folder 'generated', so before running the conversion of tsx files to strings, I added this code to remove all files.
Yejin0O0
reviewed
Jan 15, 2025
| @@ -1,32 +1,82 @@ | |||
| import path from "node:path"; | |||
| import fs from "fs-extra"; | |||
|
|
|||
| // const convertTsxToString = async () => { | |||
There was a problem hiding this comment.
I think we need to look at why the function execution depends on the local.
…uccess-info-dialog-to-interrupt-category
kimeodml
deleted the
75-refactor-move-success-info-dialog-to-interrupt-category
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR? 🔍
Changes 📝
Base.tsxfileScreenShot 📷
Precaution