Remove legacy suggester code (#722)

README.md

@@ -161,9 +161,3 @@ This tool indexes yelp reviews available at [Yelp dataset challenge](https://www
 ```
 ./gradlew clean installDist :test -PincludePerfTests=* --tests "com.yelp.nrtsearch.server.YelpReviewsTest.runYelpReviews" --info
 ```
-
-# Suggestions
-
-This test indexes businesses, creates an Infix Suggester and fetches suggestions. It requires a host, a port and a writeable directory in a standalone nrtSearch server.
-
-```./gradlew :test -DsuggestTmp=remoteServerDir -DsuggestHost=yourStandaloneServerHost -DsuggestPort=yourStandaloneServerHost --tests "com.yelp.nrtsearch.server.YelpSuggestTest"```

build.gradle

@@ -171,7 +171,6 @@ test {
     } else {
         if (!project.hasProperty('includePerfTests')) {
             exclude '**/YelpReviewsTest.class'
-            exclude '**/YelpSuggestTest.class'
             exclude '**/MergeBehaviorTests.class'
             exclude '**/IncrementalDataCleanupCommandTest.class'
             filter {

clientlib/src/main/proto/yelp/nrtsearch/luceneserver.proto

@@ -3,7 +3,6 @@ syntax = "proto3";
 
 import "yelp/nrtsearch/search.proto";
 import "yelp/nrtsearch/analysis.proto";
-import "yelp/nrtsearch/suggest.proto";
 import "google/api/annotations.proto";
 import "google/api/httpbody.proto";
 import "google/protobuf/any.proto";
@@ -215,31 +214,6 @@ service LuceneServer {
 
     }
 
-    /* Builds a new auto-suggester, loading suggestions via the provided local file path.*/
-    rpc buildSuggest (BuildSuggestRequest) returns (BuildSuggestResponse) {
-        option (google.api.http) = {
-      post: "/v1/suggest_build"
-      body: "*"
-    };
-
-    }
-    /* Perform an auto-suggest lookup.*/
-    rpc suggestLookup (SuggestLookupRequest) returns (SuggestLookupResponse) {
-        option (google.api.http) = {
-      post: "/v1/suggest_lookup"
-      body: "*"
-    };
-
-    }
-    /* Updates existing suggestions, if the suggester supports near-real-time changes. */
-    rpc updateSuggest (BuildSuggestRequest) returns (BuildSuggestResponse) {
-        option (google.api.http) = {
-      post: "/v1/suggest_update"
-      body: "*"
-    };
-
-    }
-
     /*
     Creates a snapshot in the index, which is saved point-in-time view of the last commit
     in the index such that no files referenced by that snapshot will be deleted by ongoing
@@ -298,7 +272,7 @@ service LuceneServer {
     };
     }
 
-    /* Gets the state of a started index, includes settings, live_settings, search schema, suggest schema */
+    /* Gets the state of a started index, includes settings, live_settings, search schema */
     rpc state (StateRequest) returns (StateResponse) {
         option (google.api.http) = {
         post: "/v1/state"

grpc-gateway/Dockerfile

@@ -70,8 +70,7 @@ RUN protoc \
 --go_out=plugins=grpc:$OUTPATH \
 $PROTO_PATH/yelp/nrtsearch/analysis.proto \
 $PROTO_PATH/yelp/nrtsearch/luceneserver.proto \
-$PROTO_PATH/yelp/nrtsearch/search.proto \
-$PROTO_PATH/yelp/nrtsearch/suggest.proto
+$PROTO_PATH/yelp/nrtsearch/search.proto
 
 RUN protoc \
 -I $PROTO_PATH \
@@ -81,8 +80,7 @@ RUN protoc \
 --grpc-gateway_out=logtostderr=true:$OUTPATH \
 $PROTO_PATH/yelp/nrtsearch/analysis.proto \
 $PROTO_PATH/yelp/nrtsearch/luceneserver.proto \
-$PROTO_PATH/yelp/nrtsearch/search.proto \
-$PROTO_PATH/yelp/nrtsearch/suggest.proto
+$PROTO_PATH/yelp/nrtsearch/search.proto
 
 RUN protoc \
 -I $PROTO_PATH \
@@ -92,8 +90,7 @@ RUN protoc \
 --openapiv2_out=logtostderr=true:$OUTPATH \
 $PROTO_PATH/yelp/nrtsearch/analysis.proto \
 $PROTO_PATH/yelp/nrtsearch/luceneserver.proto \
-$PROTO_PATH/yelp/nrtsearch/search.proto \
-$PROTO_PATH/yelp/nrtsearch/suggest.proto
+$PROTO_PATH/yelp/nrtsearch/search.proto
 
 RUN cp $OUTPATH/yelp/nrtsearch/* grpc-gateway/
 RUN cp $OUTPATH/github.com/Yelp/nrtsearch/* grpc-gateway/