Make _ID field always searchable (#734)

Yelp · Sep 27, 2024 · 6dd6085 · 6dd6085
1 parent 49a8f92
commit 6dd6085
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 0 deletions.
diff --git a/src/main/java/com/yelp/nrtsearch/server/luceneserver/field/IdFieldDef.java b/src/main/java/com/yelp/nrtsearch/server/luceneserver/field/IdFieldDef.java
@@ -76,6 +76,11 @@ protected void setSearchProperties(FieldType fieldType, Field requestField) {
     fieldType.setTokenized(false);
   }
 
+  @Override
+  public boolean isSearchable() {
+    return true;
+  }
+
   /**
    * Store the docvalues if it's requested and store the string value in the document
    *

diff --git a/src/test/java/com/yelp/nrtsearch/server/luceneserver/field/IdFieldTest.java b/src/test/java/com/yelp/nrtsearch/server/luceneserver/field/IdFieldTest.java
@@ -80,4 +80,26 @@ public void testStoredFields() {
     assertEquals(1, hit.getFieldsOrThrow("id").getFieldValueCount());
     assertEquals("3", hit.getFieldsOrThrow("id").getFieldValue(0).getTextValue());
   }
+
+  @Test
+  public void testAlwaysSearchable() {
+    SearchResponse response =
+        getGrpcServer()
+            .getBlockingStub()
+            .search(
+                SearchRequest.newBuilder()
+                    .setIndexName(DEFAULT_TEST_INDEX)
+                    .setTopHits(3)
+                    .addRetrieveFields("id")
+                    .setQuery(
+                        Query.newBuilder()
+                            .setTermQuery(
+                                TermQuery.newBuilder().setField("id").setTextValue("2").build())
+                            .build())
+                    .build());
+    assertEquals(1, response.getHitsCount());
+    SearchResponse.Hit hit = response.getHits(0);
+    assertEquals(1, hit.getFieldsOrThrow("id").getFieldValueCount());
+    assertEquals("2", hit.getFieldsOrThrow("id").getFieldValue(0).getTextValue());
+  }
 }