Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #693

Merged
merged 6 commits into from
Aug 20, 2024
Merged

Update dependencies #693

merged 6 commits into from
Aug 20, 2024

Conversation

sarthakn7
Copy link
Contributor

@sarthakn7 sarthakn7 commented Aug 15, 2024

RP-11378

Update most dependencies to the latest versions. gRPC and protobuf dependencies are the latest workable versions. Bumping gRPC beyond 1.60.2 is throwing errors like this:

/nail/home/sarthakn/nrtsearch/clientlib/build/generated/source/proto/main/java/com/yelp/nrtsearch/server/grpc/MultiFunctionScoreQuery.java:3039: error: type argument com.google.type.LatLng.Builder is not within bounds of type-variable BType
              com.google.type.LatLng, com.google.type.LatLng.Builder, com.google.type.LatLngOrBuilder>(
                                                            ^
  where BType is a type-variable:
    BType extends com.google.protobuf.GeneratedMessage.Builder declared in class SingleFieldBuilder

I will work on bumping these gRPC and protobuf versions separately. I have added some comments to explain the code changes required.

@sarthakn7 sarthakn7 marked this pull request as ready for review August 19, 2024 23:25
@sarthakn7 sarthakn7 requested a review from aprudhomme August 19, 2024 23:25
@sarthakn7 sarthakn7 merged commit a7f3dee into 1.0.0-SNAPSHOT Aug 20, 2024
1 check passed
@sarthakn7 sarthakn7 deleted the sarthakn_update_dependencies branch August 20, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants