Use yyyyMMddHHmmssSSS formatted datetime instead of UUID for index id #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aprudhomme
reviewed
Aug 21, 2024
...in/java/com/yelp/nrtsearch/tools/nrt_utils/legacy/incremental/RestoreIncrementalCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/com/yelp/nrtsearch/tools/nrt_utils/state/UpdateGlobalIndexStateCommand.java
Outdated
Show resolved
Hide resolved
aprudhomme
reviewed
Aug 21, 2024
aprudhomme
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RP-9696
Use yyyyMMddHHmmssSSS formatted datetime instead of UUID for index id so that we can make sense of the order of ids both programmatically and also when manually looking at files in S3.
I have replaced the index id in the commands instead of moving to legacy as I don't think we need backward compatibility here. When needing to operate in old index id, we would use old nrtsearch version anyway.