Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grpc version to 1.66 and protobuf to 3.25.3 #698

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

sarthakn7
Copy link
Contributor

@sarthakn7 sarthakn7 commented Aug 22, 2024

RP-11378

Update grpc dependency to 1.66 and protobuf to 3.25.3. The grpc-core dependency was changed from api to implementation is some of the grpc dependencies, requiring adding grpc-inprocess and proto-google-common-protos. I've added proto-google-common-protos as an api dependency in clientlib so that users of the clientlib don't have to add this separately. The grpc-inprocess dependency is used for tests only, so it should be fine to keep it under testImplementation.

@sarthakn7 sarthakn7 marked this pull request as ready for review August 22, 2024 18:35
@sarthakn7 sarthakn7 requested a review from aprudhomme August 22, 2024 18:35
@sarthakn7 sarthakn7 merged commit cc78438 into 1.0.0-SNAPSHOT Aug 22, 2024
1 check passed
@sarthakn7 sarthakn7 deleted the sarthakn_update_grpc_version_1_66 branch August 22, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants