Remove all references to Archiver #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarthakn7
reviewed
Sep 18, 2024
| @@ -22,13 +22,6 @@ java { | |||
| group 'com.yelp.nrtsearch.plugins' | |||
| version '0.0.1' | |||
|
|
|||
| repositories { | |||
| mavenCentral() | |||
There was a problem hiding this comment.
Should we still keep mavenCentral() here?
There was a problem hiding this comment.
There are two repositories blocks in this file for some reason https://github.com/Yelp/nrtsearch/pull/718/files/ab52631be40ff6bee2a75a7b58b93428d0547bfc#diff-ea04739ba1d9c1327164c174b91d0ed9ff951aee3753257514de672b9bf23b84R9
sarthakn7
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Archiverinterface has been replaced byRemoteBackend. This removes all the old incremental backup code and cleans up all references to the archiver.I also had to change the example-plugin nrtsearch version specifier because it was resolving to the SNAPSHOT artifact.