Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move cli classes out of the server package #725

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Move cli classes out of the server package #725

merged 2 commits into from
Sep 20, 2024

Conversation

sarthakn7
Copy link
Contributor

@sarthakn7 sarthakn7 commented Sep 20, 2024 •
edited
Loading

Simple refactor, moved everything under com.yelp.nrtsearch.server.cli to com.yelp.nrtsearch.tools.cli

Quick test:

$ ./build/install/nrtsearch/bin/lucene-client --version
1.0.0-alpha.1

@sarthakn7 sarthakn7 marked this pull request as ready for review September 20, 2024 20:10
@sarthakn7 sarthakn7 merged commit b384268 into main Sep 20, 2024
1 check passed
@sarthakn7 sarthakn7 deleted the sarthakn_move_cli_to_tools branch September 20, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aprudhomme aprudhomme aprudhomme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarthakn7 @aprudhomme