Fix race condition in initial point sync #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarthakn7
approved these changes
Sep 25, 2024
aprudhomme
added a commit
to aprudhomme/nrtsearch
that referenced
this pull request
Sep 25, 2024
aprudhomme
added a commit
that referenced
this pull request
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply some fixes to the initial nrt point sync
curVersionafter the copy job completes, to ensure the latest version is used in the while condition. Otherwise, there may be an extra loop iteration/copy job run.MAX_VALUEto start the copy job. This was initially done to ensure a job always starts, but this can cause issues if a new job is created when the index version has not changed on the primary.