Update mmap preload usage and config #730
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new version of lucene lets you specify a predicate for determining which files should be preloaded by an
MMapDirectory
. This lets us simplify our usage and remove theSplitMMapDirectory
.Preloading is now compatible with using
FSDirectory
. If the directory implementation is anMMapDirectory
, it will get configured for preloading.Additionally:
false
. This feature has some large resource implications and should be deliberately enabled. Since we default toFSDirectory
, preload would have been disabled by default prior to this change.