Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mmap preload usage and config #730

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

aprudhomme
Copy link
Contributor

The new version of lucene lets you specify a predicate for determining which files should be preloaded by an MMapDirectory. This lets us simplify our usage and remove the SplitMMapDirectory.

Preloading is now compatible with using FSDirectory. If the directory implementation is an MMapDirectory, it will get configured for preloading.

Additionally:

  • The config has been updated to use the 'preload.` prefix. This will make it cleaner to add more properties (for example, using the context as part of the decision)
  • The default value is now false. This feature has some large resource implications and should be deliberately enabled. Since we default to FSDirectory, preload would have been disabled by default prior to this change.

@aprudhomme aprudhomme merged commit 680bd73 into Yelp:main Sep 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants