Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work in progress to include Ed25519, P384 and P521 into FIDO #186

Draft
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

DennisDyallo
Copy link
Collaborator

Description

Please include a summary of the change and which issue is fixed, as well as relevant motivation and context. Finally, list any dependencies that are required for this change if any.

Fixes: # <link to issue(s)>

Type of change

  • Refactor (non-breaking change which improves code quality or performance)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test configuration:

  • OS version: e.g. Windows 11
  • Firmware version: e.g. 5.7.2
  • Yubikey model1:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have run dotnet format to format my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Footnotes

  1. See Yubikey models (Multi-protocol, Security Key, FIPS, Bio, YubiHSM, YubiHSM FIPS)

@DennisDyallo DennisDyallo marked this pull request as draft January 11, 2025 14:58
@DennisDyallo DennisDyallo added the enhancement New feature or request label Jan 11, 2025
Copy link

github-actions bot commented Jan 11, 2025

Test Results: Windows

    2 files      2 suites   4s ⏱️
3 741 tests 3 741 ✅ 0 💤 0 ❌
3 743 runs  3 743 ✅ 0 💤 0 ❌

Results for commit d8e8bfe.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 11, 2025

Test Results: Ubuntu

    2 files      2 suites   10s ⏱️
3 733 tests 3 733 ✅ 0 💤 0 ❌
3 735 runs  3 735 ✅ 0 💤 0 ❌

Results for commit d8e8bfe.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 11, 2025

Test Results: MacOS

    2 files      2 suites   4s ⏱️
3 733 tests 3 733 ✅ 0 💤 0 ❌
3 735 runs  3 735 ✅ 0 💤 0 ❌

Results for commit d8e8bfe.

♻️ This comment has been updated with latest results.

Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
Yubico.Core 44% 32% 4317
Yubico.YubiKey 49% 46% 19761
Summary 48% (33392 / 69201) 43% (8248 / 19035) 24078

Minimum allowed line rate is 40%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

1 participant