Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tensors/heads not divisible by GPUs #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

siddartha-RE
Copy link

Got it to where model weight are loading correctly. Hitting the attention heads are partitioned, I think because the qk header 192 and v heads are 128. May not be a huge priority. It gets through loading weights and it does correctly spread the memory. It just fails a reshape due to assumptions on the number of heads in each partition.

Copy link

github-actions bot commented Feb 3, 2025

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@siddartha-RE
Copy link
Author

More just an FYI in what needs to be fixed to support non divisible tensors.

@siddartha-RE siddartha-RE force-pushed the support_non_divisible_dims branch from 98a5d9a to 641fb85 Compare February 3, 2025 18:36
@siddartha-RE siddartha-RE force-pushed the support_non_divisible_dims branch from 641fb85 to a059d4a Compare February 4, 2025 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants