Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: navbar design changes and position fixed added #176

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

OINDIL
Copy link

@OINDIL OINDIL commented Oct 12, 2024

Issue #80

Problem

The Navbar was outdated, so I fixed the design as @abhishekraoas told me.

Fixes

  1. Implemented GSSoC design with colour and background changes to match the previous theme.
  2. Changed the dark mode toggle to use a single image as a button.

Final Design

image

Copy link

vercel bot commented Oct 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mmmut-mca ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2024 6:42am

Copy link

netlify bot commented Oct 12, 2024

Deploy Preview for mmmutmcanetwork ready!

Name Link
🔨 Latest commit 082f760
🔍 Latest deploy log https://app.netlify.com/sites/mmmutmcanetwork/deploys/670a1a5646876a000813299e
😎 Deploy Preview https://deploy-preview-176--mmmutmcanetwork.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better

Copy link

netlify bot commented Oct 12, 2024

Deploy Preview for mmmut-mca ready!

Name Link
🔨 Latest commit 082f760
🔍 Latest deploy log https://app.netlify.com/sites/mmmut-mca/deploys/670a1a568f693000098bd088
😎 Deploy Preview https://deploy-preview-176--mmmut-mca.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@abhishekraoas
Copy link
Owner

looking good but it's not working properly

{0AF72A1D-253E-4E78-8D94-DBAB356D4EA6}

@OINDIL
Copy link
Author

OINDIL commented Oct 12, 2024

Yes that is because of the fixed property, if you want to change it then the navbar won't be fixed at the top, and it was on the GSSoC official navbar that's why I added it!

@OINDIL
Copy link
Author

OINDIL commented Oct 12, 2024

I will fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants