Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set resolveProvider capability to false #67

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

neilyio
Copy link

@neilyio neilyio commented Jul 15, 2023

It's my understanding that the resolveProvider: true property in the completionProvider capability in the Language Server Protocol (LSP) signals that the language server can resolve extra details for a completion item. A language server that specifies resolveProvider: true should typically implement a completionItem/resolve handler, which the client will call to resolve a completion item returned from the textDocument/completion request.

The client I'm using, helix, checks the completionProvider capbility, sees true, and calls completionItem/resolve. Since the emmet-ls connection doesn't implement onCompletionResolve, this causes a "method unhandled" error.

The comment in server.ts suggests that resolveProvider may have been set to true with the assumption that it simply enables completion. It should be false unless emmet-ls chooses to implement completionItem/resolve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant