Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URL version issue for docusign-connect template #431

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

itschetna
Copy link

Closes #390

This pull request fixes the invalid link for the docusign-connect template on the Accord Project Template Studio home page.

Changes

Updated the docusign-connect link in package.json to reference version 0.9.0 instead of 0.10.0.
Ensured that the correct link is now functional and redirects properly.
Flags

Verified functionality of the updated link in the Template Studio environment.
Screenshots or Video

No screenshots applicable as this is a backend link update.

Related Issues
Issue #390

@sanketshevkar
Copy link
Member

@DianaLease how can we trigger the pipeline?

Copy link
Member

@DianaLease DianaLease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think downgrading the version is the correct way to fix this. We should see why version 0.10.0 didn't get published correctly to https://templates.accordproject.org/[email protected].

@itschetna
Copy link
Author

@DianaLease
Screenshot 2025-01-08 105417
I have investigated the issue with the broken link for [email protected] on https://templates.accordproject.org/, and found that the root cause is related to the content of the file for version 0.10.0. It appears that the file only contains the basic HTML structure () and lacks the necessary template data for this version. As a result, the link leads to an empty page.

@sanketshevkar
Copy link
Member

@DianaLease is there any other source from where we can fetch/get this models?

@DianaLease
Copy link
Member

@dselman do you know how the html gets generated for new versions of templates? It seems like it didn't correctly get generated for 0.10.0 of the docusign-connect template resulting in an empty page at https://templates.accordproject.org/[email protected]

@dselman
Copy link
Contributor

dselman commented Jan 30, 2025

@dselman do you know how the html gets generated for new versions of templates? It seems like it didn't correctly get generated for 0.10.0 of the docusign-connect template resulting in an empty page at https://templates.accordproject.org/[email protected]

https://github.com/accordproject/cicero-template-library/blob/main/run.js uses Nunjucks templates to generate the HTML. Try running it locally to debug the failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid Link for Docusign Connect at Home Page
4 participants