Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve - medic param to remaining treatment EHs #10186

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tuntematonjr
Copy link
Contributor

When merged this pull request will:

  • add medic parameter to remaining local treatment events

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@tuntematonjr
Copy link
Contributor Author

tuntematonjr commented Aug 10, 2024

it seems that these are not in https://ace3.acemod.org/wiki/framework/events-framework#22-medical-ace_medical
should i add those there?

@PabstMirror
Copy link
Contributor

generally

  • treatment_fnc_x handles the logging based on the medic and then sends event to
  • treatment_fnc_xLocal which just does the actual healing

So I'm not sure why is this needed?

@tuntematonjr
Copy link
Contributor Author

Some use the local event for patients to display message that someone is healing you, this would allow just showing the medics name there.
I was trying to do that and noticed that some of the local evets did not have the medic param transfered.

But yeah, it can also be done from the medics event or ace_treatmentStarted, ace_treatmentSucceded, ace_treatmentFailed.
So if you think this is too minor thing, this can be closed.

@PabstMirror
Copy link
Contributor

sorry this got delayed,
do you still have a use for this? I know your excellent TunCon mod already updated

if we use this, we'll have to add something for medical_ai because they also call these same events

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants