feat: make all rules error
instead of warn
#356
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally when I authored our configs I set a handful of rules to
warn
instead oferror
as a way of making the configs gentler and hint to people when it might be ok to actually disable the rule for that particular violation depending on the context.In practice however, most people tend to expect the linter to block in CI and that if it doesn't then everything is fine, meaning the rules configured to
warn
were effectively the same as not being enabled at all except for when people run--fix
.When we've talked about this recently, the general consensus was people would prefer the rules just
error
, and so that's what this does