Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make all rules error instead of warn #356

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Feb 5, 2025

Originally when I authored our configs I set a handful of rules to warn instead of error as a way of making the configs gentler and hint to people when it might be ok to actually disable the rule for that particular violation depending on the context.

In practice however, most people tend to expect the linter to block in CI and that if it doesn't then everything is fine, meaning the rules configured to warn were effectively the same as not being enabled at all except for when people run --fix.

When we've talked about this recently, the general consensus was people would prefer the rules just error, and so that's what this does

Copy link

@robotdana robotdana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i agree, if it doesn't fail ci it doesn't exist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants