Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote echo $data in _porkbun_rest (dns_porkbun) #5041

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

j-c-m
Copy link
Contributor

@j-c-m j-c-m commented Mar 7, 2024

Quote echo $data in _porkbun_rest to avoid
brace expansion under ksh (OpenBSD).

Quote echo $data in _porkbun_rest to avoid
brace expansion under ksh (OpenBSD).
Copy link

github-actions bot commented Mar 7, 2024

Welcome
First thing: don't send PR to the master branch, please send to the dev branch instead.
Please make sure you've read our DNS API Dev Guide and DNS-API-Test.
Then reply on this message, otherwise, your code will not be reviewed or merged.
We look forward to reviewing your Pull request shortly ✨
注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

@j-c-m
Copy link
Contributor Author

j-c-m commented Mar 7, 2024 via email

@j-c-m
Copy link
Contributor Author

j-c-m commented Mar 7, 2024

@j-c-m j-c-m changed the title Quote echo $data in _porkbun_rest Quote echo $data in _porkbun_rest (dns_porkbun) Mar 11, 2024
@j-c-m
Copy link
Contributor Author

j-c-m commented Jun 13, 2024

Welcome First thing: don't send PR to the master branch, please send to the dev branch instead. Please make sure you've read our DNS API Dev Guide and DNS-API-Test. Then reply on this message, otherwise, your code will not be reviewed or merged. We look forward to reviewing your Pull request shortly ✨ 注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

OK?

@Neilpang Neilpang merged commit 58cad98 into acmesh-official:dev Jun 15, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants