-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes issue 4956: 'Linode DNS Pagination Bug' #5172
Conversation
fixes issue acmesh-official#4956 previous code only worked for the first 10 domains on the account (as Linode API returned a paginated response, with only 10 records). This change makes an exact search query for each subdomain, completely removing any need for walking through paginated responses. What makes it work for large accounts with any number of domains.
Welcome |
minor fix for text coherence
fix minor problems reported by shellcheck and shfmt
Can this be merged into dev, please? |
Hi @Neilpang, I tried testing it accordingly to what is written in the DNS-API-Test, but there's a job that fails. I also couldn't ask for help because the repository was closed for new commenters last week. Currently there's a job failing:
I've read the instructions several times, but it's not clear what I'm doing wrong. From the msg above it looks like it's not expecting the tests to run on my account, though for what I understand, the instructions on DNS-API-Test tell that secrets should be set on my account. Can you please help? |
I think the instructions are clear enough. I wish I could help. |
was unintendedly replaying the save _H4 header on all requests, what was causing random failures on responses from the API.
the same pagination bug that happens for accounts with a large number of domains also happens for DNS zones with a large number of records. The previous code assumes that all records are returned in a single page. Changed the code to do an exact match search so that it returns only the few required records and never paginates replies.
Hi @Neilpang. I figured it out. Thanks for the reply anyway. This is done. It's ready for testing and merging. |
fixes issue #4956
previous code only worked for the first 10 domains on the account (as Linode API returned a paginated response, with only 10 records).
This change makes an exact search query for each subdomain, completely removing any need for walking through paginated responses. What makes it work for large accounts with any number of domains.