Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for azure arc servers #5211

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

Kisbogyi
Copy link

@Kisbogyi Kisbogyi commented Jul 18, 2024

This code will enable the azure module to work in Azure arc servers as well, because azure arc servers use a separate url, and method for the challenge/response protocol.
https://learn.microsoft.com/en-us/azure/azure-arc/servers/managed-identity-authentication

Copy link

Welcome
First thing: don't send PR to the master branch, please send to the dev branch instead.
Please make sure you've read our DNS API Dev Guide and DNS-API-Test.
Then reply on this message, otherwise, your code will not be reviewed or merged.
We look forward to reviewing your Pull request shortly ✨
注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

@Kisbogyi
Copy link
Author

orward to reviewing your Pull r

👍

@GBBx
Copy link

GBBx commented Oct 28, 2024

Hi,
Thanks @Kisbogyi , this is a great improvement. I'd love to see it merged.
This change could fix the shellcheck:

      CHALLENGE=$(grep Www "$HTTP_HEADER" | sed 's/Www-Authenticate: Basic realm=//g' | sed 's/[^a-zA-Z0-9\/\.\-]//g')
      _H2="Authorization: Basic $(cat "$CHALLENGE")"

(Also fix a typo.)


Another thing: the tokens are in "/var/opt/azcmagent/tokens/" and not all users have access to it so acme.sh may need to be run by root for this scenario.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants