Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert txt add update #5331

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Conversation

lifeboy
Copy link
Contributor

@lifeboy lifeboy commented Oct 16, 2024

This is to undo the change made by PR5268.

Neilpang and others added 2 commits October 13, 2024 18:02
The change was needed for Power-Mailinabox and broke Mail-in-a-box, so a new API for Power-Mailinabox has been added
Copy link

Welcome
First thing: don't send PR to the master branch, please send to the dev branch instead.
Please make sure you've read our DNS API Dev Guide and DNS-API-Test.
Then reply on this message, otherwise, your code will not be reviewed or merged.
We look forward to reviewing your Pull request shortly ✨
注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

@Neilpang
Copy link
Member

why

@lifeboy
Copy link
Contributor Author

lifeboy commented Oct 16, 2024

why

The Power-Mailinabox (PMIAB) and Mailinabox (MIAB) DNS API's are now different. The format I added applies only to PMIAB, which is a fork or MIAB, but with enhancements. I was led to believe the API enhancement came from MIAB, but it didn't. So I created a new DNS API for PMIAB, which I have already sent a PR fpr. This here is to undo the damage to the MIAB DNS.

@Neilpang Neilpang merged commit 5c78a5e into acmesh-official:dev Oct 16, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants