add some properties and methods missing on Parser class #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marijnh
reviewed
Feb 10, 2022
acorn/dist/acorn.d.ts
Outdated
| @@ -36,8 +38,47 @@ declare namespace acorn { | |||
| } | |||
|
|
|||
| class Parser { | |||
| // state.js | |||
| lineStart: number; | |||
| options: { | |||
There was a problem hiding this comment.
Commit added to change...
marijnh
reviewed
Feb 10, 2022
acorn/dist/acorn.d.ts
Outdated
| unexpected(pos: number) : void; | ||
|
|
||
| // index.js | ||
| static acorn: { |
There was a problem hiding this comment.
It seems like static acorn: typeof acorn would work here to automatically include all exports.
There was a problem hiding this comment.
Ok, cool. Seems like that will work. Commit added.
|
Thank you. Found one more nitpick, looks fine after that. |
|
Thank you! |
This was referenced Feb 10, 2022
brettz9
added a commit
to brettz9/espree
that referenced
this pull request
Feb 12, 2022
0. depends on acorn and acorn-jsx being updated per PRs
a. acornjs/acorn#1104 (merged but not yet released)
b. acornjs/acorn#1105
c. acornjs/acorn-jsx#130
1. Refactor to avoid `typedef` shortcuts when not desired for export
2. Avoid dummy class, so parse JavaScript with https://github.com/es-joy/jsdoc-eslint-parser
feat: Adds JSDoc-based TypeScript declaration file
Also:
1. chore: adds `editorconfig`
2. refactor: Removes unused esprima
3. refactor: changes to force EspreeParser constructor to convert `new String` to plain string (for typing)
4. refactor: switches to `Object.keys` to avoid `hasOwnProperty` and easier for typing
5. refactor: drops a use of `acorn.Parser.extend` for typing purposes
6. refactor: checks for existence of `tokens` in `tokenize` (as may be absent)
7. refactor: checks for existence of `firstNode.range` and `firstNode.loc` in `parse` (as may be absent)
8. refactor: checks for existence of `extra.lastToken.range` and `extra.lastToken.loc` in `parse` (as may be absent)
7. feat: throws specific error if `jsx_readString` superclass undefined
8. refactor: checks for existence of `lastTemplateToken.loc` and `lastTemplateToken.range` in `token-translator.js` (as may be absent)
brettz9
added a commit
to brettz9/espree
that referenced
this pull request
Feb 12, 2022
0. depends on acorn and acorn-jsx being updated per PRs
a. acornjs/acorn#1104 (merged but not yet released)
b. acornjs/acorn#1105 (merged but not yet released)
c. acornjs/acorn-jsx#130
1. Refactor to avoid `typedef` shortcuts when not desired for export
2. Avoid dummy class, so parse JavaScript with https://github.com/es-joy/jsdoc-eslint-parser
feat: Adds JSDoc-based TypeScript declaration file
Also:
1. chore: adds `editorconfig`
2. refactor: Removes unused esprima
3. refactor: changes to force EspreeParser constructor to convert `new String` to plain string (for typing)
4. refactor: switches to `Object.keys` to avoid `hasOwnProperty` and easier for typing
5. refactor: drops a use of `acorn.Parser.extend` for typing purposes
6. refactor: checks for existence of `tokens` in `tokenize` (as may be absent)
7. refactor: checks for existence of `firstNode.range` and `firstNode.loc` in `parse` (as may be absent)
8. refactor: checks for existence of `extra.lastToken.range` and `extra.lastToken.loc` in `parse` (as may be absent)
7. feat: throws specific error if `jsx_readString` superclass undefined
8. refactor: checks for existence of `lastTemplateToken.loc` and `lastTemplateToken.range` in `token-translator.js` (as may be absent)
brettz9
added a commit
to brettz9/espree
that referenced
this pull request
Feb 12, 2022
0. depends on acorn and acorn-jsx being updated per PRs
a. acornjs/acorn#1104 (merged but not yet released)
b. acornjs/acorn#1105 (merged but not yet released)
c. acornjs/acorn-jsx#130
1. Refactor to avoid `typedef` shortcuts when not desired for export
2. Avoid dummy class, so parse JavaScript with https://github.com/es-joy/jsdoc-eslint-parser
feat: Adds JSDoc-based TypeScript declaration file
Also:
1. chore: adds `editorconfig`
2. refactor: Removes unused esprima
3. refactor: changes to force EspreeParser constructor to convert `new String` to plain string (for typing)
4. refactor: switches to `Object.keys` to avoid `hasOwnProperty` and easier for typing
5. refactor: drops a use of `acorn.Parser.extend` for typing purposes
6. refactor: checks for existence of `tokens` in `tokenize` (as may be absent)
7. refactor: checks for existence of `firstNode.range` and `firstNode.loc` in `parse` (as may be absent)
8. refactor: checks for existence of `extra.lastToken.range` and `extra.lastToken.loc` in `parse` (as may be absent)
7. feat: throws specific error if `jsx_readString` superclass undefined
8. refactor: checks for existence of `lastTemplateToken.loc` and `lastTemplateToken.range` in `token-translator.js` (as may be absent)
brettz9
added a commit
to brettz9/espree
that referenced
this pull request
Mar 10, 2022
0. depends on acorn and acorn-jsx being updated per PRs
a. acornjs/acorn#1104 (merged but not yet released)
b. acornjs/acorn#1105 (merged but not yet released)
c. acornjs/acorn-jsx#130
1. Refactor to avoid `typedef` shortcuts when not desired for export
2. Avoid dummy class, so parse JavaScript with https://github.com/es-joy/jsdoc-eslint-parser
feat: Adds JSDoc-based TypeScript declaration file
Also:
1. chore: adds `editorconfig`
2. refactor: Removes unused esprima
3. refactor: changes to force EspreeParser constructor to convert `new String` to plain string (for typing)
4. refactor: switches to `Object.keys` to avoid `hasOwnProperty` and easier for typing
5. refactor: drops a use of `acorn.Parser.extend` for typing purposes
6. refactor: checks for existence of `tokens` in `tokenize` (as may be absent)
7. refactor: checks for existence of `firstNode.range` and `firstNode.loc` in `parse` (as may be absent)
8. refactor: checks for existence of `extra.lastToken.range` and `extra.lastToken.loc` in `parse` (as may be absent)
7. feat: throws specific error if `jsx_readString` superclass undefined
8. refactor: checks for existence of `lastTemplateToken.loc` and `lastTemplateToken.range` in `token-translator.js` (as may be absent)
brettz9
added a commit
to brettz9/espree
that referenced
this pull request
Apr 21, 2022
0. depends on acorn and acorn-jsx being updated per PRs
a. acornjs/acorn#1104 (merged but not yet released)
b. acornjs/acorn#1105 (merged but not yet released)
c. acornjs/acorn-jsx#130
1. Refactor to avoid `typedef` shortcuts when not desired for export
2. Avoid dummy class, so parse JavaScript with https://github.com/es-joy/jsdoc-eslint-parser
feat: Adds JSDoc-based TypeScript declaration file
Also:
1. chore: adds `editorconfig`
2. refactor: Removes unused esprima
3. refactor: changes to force EspreeParser constructor to convert `new String` to plain string (for typing)
4. refactor: switches to `Object.keys` to avoid `hasOwnProperty` and easier for typing
5. refactor: drops a use of `acorn.Parser.extend` for typing purposes
6. refactor: checks for existence of `tokens` in `tokenize` (as may be absent)
7. refactor: checks for existence of `firstNode.range` and `firstNode.loc` in `parse` (as may be absent)
8. refactor: checks for existence of `extra.lastToken.range` and `extra.lastToken.loc` in `parse` (as may be absent)
7. feat: throws specific error if `jsx_readString` superclass undefined
8. refactor: checks for existence of `lastTemplateToken.loc` and `lastTemplateToken.range` in `token-translator.js` (as may be absent)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
We're looking to add type support to Espree (and other projects in the ESLint space), and it looks like we could use these missing class items (especially since limiting ourselves to basic JSDoc for the TS declaration file generation makes it more useful not to have to reimplement types ourselves).
Rather new to using TypeScript, so hope I've gotten things done all right. It doesn't cover all methods and properties, but I hope this will at least improve things.
Thanks!