Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #652

Merged
merged 1 commit into from
Jan 12, 2025
Merged

Update dependencies #652

merged 1 commit into from
Jan 12, 2025

Conversation

tagliala
Copy link
Contributor

Additionally, configure two new cops to prevent the following warnings:

The following cops were added to RuboCop, but are not configured. Please set Enabled to either `true` or `false` in your `.rubocop.yml` file.

Performance/StringBytesize: # new in 1.23
  Enabled: true
RSpec/StringAsInstanceDoubleConstant: # new in 3.1
  Enabled: true

Additionally, configure two new cops to prevent the following warnings:

```
The following cops were added to RuboCop, but are not configured. Please set Enabled to either `true` or `false` in your `.rubocop.yml` file.

Performance/StringBytesize: # new in 1.23
  Enabled: true
RSpec/StringAsInstanceDoubleConstant: # new in 3.1
  Enabled: true
```
Copy link

codecov bot commented Jan 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.33%. Comparing base (97da462) to head (cfe8b9e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #652   +/-   ##
=======================================
  Coverage   94.33%   94.33%           
=======================================
  Files          17       17           
  Lines         459      459           
=======================================
  Hits          433      433           
  Misses         26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tagliala tagliala requested a review from javierjulio January 12, 2025 14:45
Copy link
Member

@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tagliala tagliala merged commit 0405ce9 into master Jan 12, 2025
22 checks passed
@tagliala tagliala deleted the chore/update-deps branch January 12, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants