test: reproduce and fix node.js bug (#511)

* test: reproduce node.js bug * fix: add missing special scheme check for setter * Fix. * formatting. --------- Co-authored-by: Daniel Lemire <[email protected]>
ada-url · Sep 19, 2023 · f4dc343 · f4dc343
1 parent b92b825
commit f4dc343
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 5 deletions.
diff --git a/include/ada/url_aggregator-inl.h b/include/ada/url_aggregator-inl.h
@@ -807,7 +807,9 @@ inline bool url_aggregator::has_hostname() const noexcept {
 
 inline bool url_aggregator::has_port() const noexcept {
   ada_log("url_aggregator::has_port");
-  return components.pathname_start != components.host_end;
+  // A URL cannot have a username/password/port if its host is null or the empty
+  // string, or its scheme is "file".
+  return has_hostname() && components.pathname_start != components.host_end;
 }
 
 inline bool url_aggregator::has_dash_dot() const noexcept {

diff --git a/src/url-setters.cpp b/src/url-setters.cpp
@@ -55,7 +55,7 @@ bool url::set_host_or_hostname(const std::string_view input) {
     }
 
     // Let host be the result of host parsing host_view with url is not special.
-    if (host_view.empty()) {
+    if (host_view.empty() && !is_special()) {
       host = "";
       return true;
     }

diff --git a/src/url_aggregator.cpp b/src/url_aggregator.cpp
@@ -552,13 +552,12 @@ bool url_aggregator::set_host_or_hostname(const std::string_view input) {
     // empty string, and either url includes credentials or url's port is
     // non-null, return.
     else if (host_view.empty() &&
-             (is_special() || has_credentials() ||
-              components.port != url_components::omitted)) {
+             (is_special() || has_credentials() || has_port())) {
       return false;
     }
 
     // Let host be the result of host parsing host_view with url is not special.
-    if (host_view.empty()) {
+    if (host_view.empty() && !is_special()) {
       if (has_hostname()) {
         clear_hostname();  // easy!
       } else if (has_dash_dot()) {

diff --git a/tests/basic_tests.cpp b/tests/basic_tests.cpp
@@ -378,3 +378,12 @@ TYPED_TEST(basic_tests, url_host_type) {
       ada::url_host_type::IPV6);
   SUCCEED();
 }
+
+// https://github.com/nodejs/node/issues/49650
+TYPED_TEST(basic_tests, nodejs_49650) {
+  auto out = ada::parse<TypeParam>("http://foo");
+  ASSERT_TRUE(out);
+  ASSERT_FALSE(out->set_host("::"));
+  ASSERT_EQ(out->get_href(), "http://foo/");
+  SUCCEED();
+}