Testing macos installation #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
reviewed
Sep 6, 2023
| @@ -50,7 +50,6 @@ set(CMAKE_EXPORT_COMPILE_COMMANDS ON) | |||
| set(CMAKE_CXX_STANDARD 17) | |||
| set(CMAKE_CXX_STANDARD_REQUIRED ON) | |||
| set(CMAKE_CXX_EXTENSIONS OFF) | |||
| set(CMAKE_MACOSX_RPATH OFF) | |||
There was a problem hiding this comment.
By default, under macOS, CMake sets the MACOSX_RPATH property on all targets. If you do it manually, you should set CMAKE_MACOSX_RPATH to false. It appears that we do not set MACOSX_RPATH, so we either need to do so, or to leave CMAKE_MACOSX_RPATH to its default value (ON).
https://cmake.org/cmake/help/latest/variable/CMAKE_MACOSX_RPATH.html
Note that this is not normally an issue because we rarely use dynamic libraries under macOS.
anonrig
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR would test macOS installation.