Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: timeout datatype in haltError #690

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: timeout datatype in haltError #690

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Wippersnapper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2504,9 +2504,9 @@ void Wippersnapper::runNetFSM() {
void Wippersnapper::haltError(String error, ws_led_status_t ledStatusColor,
uint8_t seconds_until_reboot) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should seconds_until_reboot also be uint8_t?

#ifdef ARDUINO_ARCH_ESP8266
uint8_t wdt_timeout_ms = 3200;
uint16_t wdt_timeout_ms = 3200;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function signature of enableWDTV2(int timeoutMS), which takes in this wdt_timeout_ms value is int not uint. Why are you changing it to uint16_t?

#else
uint8_t wdt_timeout_ms = 5000;
uint16_t wdt_timeout_ms = 5000;
#endif
int seconds_until_wdt_enable =
seconds_until_reboot - (int)(wdt_timeout_ms / 1000);
Expand Down
Loading