fix: better macOS asset error msg (electron#127)

Closes electron#125
adam-coster · Feb 24, 2023 · ff2d7c0 · ff2d7c0
1 parent 8eec1fa
commit ff2d7c0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/updates.js b/src/updates.js
@@ -88,7 +88,7 @@ class Updates {
 
     if (!latest) {
       const message = platform.includes(PLATFORM.DARWIN)
-        ? "No updates found (needs asset matching *{mac,darwin,osx}*.zip in public repository)"
+        ? "No updates found (needs asset matching *(mac|darwin|osx).*(-arm).*.zip in public repository)"
         : "No updates found (needs asset containing win32-{x64,ia32,arm64} or .exe in public repository)";
       notFound(res, message);
     } else if (semver.lte(latest.version, version)) {

diff --git a/test/update.test.js b/test/update.test.js
@@ -303,15 +303,15 @@ test("Updates", async (t) => {
         let body = await res.text();
         t.equal(
           body,
-          "No updates found (needs asset matching *{mac,darwin,osx}*.zip in public repository)"
+          "No updates found (needs asset matching *(mac|darwin|osx).*(-arm).*.zip in public repository)"
         );
 
         res = await fetch(`${address}/owner/repo-win32-zip/darwin/0.0.0`);
         t.equal(res.status, 404);
         body = await res.text();
         t.equal(
           body,
-          "No updates found (needs asset matching *{mac,darwin,osx}*.zip in public repository)"
+          "No updates found (needs asset matching *(mac|darwin|osx).*(-arm).*.zip in public repository)"
         );
       });
     });