Kvarga/testing improvements #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for s3 region
* 'master' of github.com:kjvarga/sitemap_generator: added support for s3 region
Updated google ping URL.
Fixes #117: add video price support * Use latest Nokogiri that supports Ruby 1.8.7 * Move schema URIs to a constant on the module. * Add prefixes to the XML fragments being validated so they validate. * Add latest Video schema * Fix PageMap specs Refs #116: Quote the ping URL so it's obvious what content is Fixes #113: Support symbols as well as strings for most arguments to add()
By default, all sitemap files will be compressed with gzip. If gzip_initial is set to false, the first sitemap file will be left uncompressed.
…helpers Adding line to README to show how you can include modules
According to the Sitemap Writer website, it updates "Google, Ask.com and Bing (Live.com)". Since Ask no longer accepts sitemaps, this service is redundant?
Remove Sitemap Writer
* Don't include Fog as part of SitemapGenerator core. * Run the S3Adapter test as an integration test, and exclude it from the regular test runs.
…ired when the adapter is loaded.
Support integer timestamps. Upgrade to v4.3.1
…rage Google Cloud Storage support
The warning is:
/var/local/bundle/ruby/2.7.0/gems/sitemap_generator-6.1.0/lib/sitemap_generator/link_set.rb:298: warning: calling URI.open via Kernel#open is deprecated, call URI.open directly or use URI#open
See https://bugs.ruby-lang.org/issues/16438 for details
NoMethodError: private method `open' called for URI:Module was raised on older rubies as URI.open was added only in Ruby 2.5: https://rubyreferences.github.io/rubychanges/2.5.html#network-and-web
Fix NoMethodError error on Ruby 2.4 and older.
add a alternates options sample code
Update README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.