Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for React 18 #3503

Merged
merged 39 commits into from
Feb 13, 2025
Merged
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
5590f80
React 19
nstepien Apr 26, 2024
b27490c
Merge branch 'main' into react19
amanmahajan7 Jul 8, 2024
ad5099d
Merge remote-tracking branch 'origin/main' into react19
nstepien Jul 15, 2024
ebc2830
beta -> rc
nstepien Jul 15, 2024
02c5eb7
Merge remote-tracking branch 'origin/main' into react19
nstepien Jul 15, 2024
929e6ca
Merge branch 'main' into react19
amanmahajan7 Jul 18, 2024
b057c8f
Merge branch 'main' into react19
nstepien Jul 18, 2024
06fb414
remove patch script
nstepien Jul 18, 2024
8cd5916
Merge branch 'main' into react19
amanmahajan7 Jul 18, 2024
4bfba76
-forwardRef
nstepien Jul 19, 2024
8a74558
use ComponentProps
nstepien Jul 19, 2024
5d1c3bf
import useLayoutEffect directly
nstepien Jul 19, 2024
c01a5b8
use contexts directly
nstepien Jul 19, 2024
fe5eb24
fix lint
nstepien Jul 19, 2024
85c0564
cleanup useRef type
nstepien Jul 19, 2024
27ee3fd
Merge branch 'main' into react19
nstepien Jul 23, 2024
5246a72
Merge remote-tracking branch 'origin/main' into react19
nstepien Sep 11, 2024
52c0643
add missing exports
nstepien Sep 11, 2024
6954550
Merge branch 'main' into react19
nstepien Sep 25, 2024
97c7af2
Merge branch 'main' into react19
amanmahajan7 Oct 8, 2024
dbdaeff
Merge branch 'main' into react19
amanmahajan7 Nov 13, 2024
4809482
Merge branch 'main' into react19
nstepien Dec 21, 2024
142d12b
use stable React 19
nstepien Dec 21, 2024
e6bc742
provider -> context
nstepien Dec 22, 2024
8040416
-1 forwardRef
nstepien Dec 22, 2024
df10bc1
add forceConsistentCasingInFileNames
nstepien Dec 22, 2024
a67188f
Merge branch 'main' into react19
nstepien Dec 29, 2024
d8c5f9a
Merge branch 'main' into react19
nstepien Jan 5, 2025
801943a
Merge branch 'main' into react19
amanmahajan7 Jan 7, 2025
dbf8cb1
Merge branch 'main' into react19
nstepien Jan 20, 2025
7ace72b
bump
nstepien Jan 20, 2025
b50c390
remove reference to old vitest.workspace.ts
nstepien Jan 20, 2025
509ef27
Merge branch 'main' into react19
nstepien Feb 13, 2025
8662aa5
update deps
nstepien Feb 13, 2025
cd660c2
remove unnecessary RefAttributes
nstepien Feb 13, 2025
619a9d2
fix types
nstepien Feb 13, 2025
8b26dd6
apply same fix to TreeDataGrid
nstepien Feb 13, 2025
69d13ae
update chromium issue links
nstepien Feb 13, 2025
24275b6
remove unused ref
nstepien Feb 13, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into react19
nstepien committed Sep 25, 2024
commit 69545500af15f143697b54d005cb0a4adc791c23
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -18,7 +18,7 @@

## Features

- [React 18.0+](package.json) support
- [React 19.0+](package.json) support
- [Evergreen browsers and server-side rendering](browserslist) support
- Tree-shaking support and only [one npm dependency](package.json) to keep your bundles slim
- Great performance thanks to virtualization: columns and rows outside the viewport are not rendered
5 changes: 2 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
@@ -77,8 +77,8 @@
"@types/node": "^22.0.0",
"@types/react": "npm:types-react@rc",
"@types/react-dom": "npm:types-react-dom@rc",
"@typescript-eslint/eslint-plugin": "^8.1.0",
"@typescript-eslint/parser": "^8.1.0",
"@typescript-eslint/eslint-plugin": "^8.7.0",
"@typescript-eslint/parser": "^8.7.0",
"@vitejs/plugin-react": "^4.3.1",
"@vitest/browser": "^2.1.1",
"@vitest/coverage-v8": "^2.1.1",
@@ -101,7 +101,6 @@
"react-dnd": "^16.0.1",
"react-dnd-html5-backend": "^16.0.1",
"react-dom": "rc",
"react-router-dom": "^6.11.1",
"rollup": "^4.0.2",
"rollup-plugin-postcss": "^4.0.2",
"typescript": "~5.6.2",
7 changes: 1 addition & 6 deletions src/DragHandle.tsx
Original file line number Diff line number Diff line change
@@ -32,19 +32,14 @@ const cellDragHandleFrozenClassname = css`

const cellDragHandleClassname = `rdg-cell-drag-handle ${cellDragHandle}`;

// TODO: replace with RefObject once we drop support for React 18
interface LatestDraggedOverRowIdxRef {
readonly current: number | undefined;
}

interface Props<R, SR> extends Pick<DataGridProps<R, SR>, 'rows' | 'onRowsChange'> {
gridRowStart: number;
column: CalculatedColumn<R, SR>;
columnWidth: number | string;
maxColIdx: number;
isLastRow: boolean;
selectedPosition: SelectCellState;
latestDraggedOverRowIdx: LatestDraggedOverRowIdxRef;
latestDraggedOverRowIdx: React.RefObject<number | undefined>;
isCellEditable: (position: Position) => boolean;
onClick: () => void;
onFill: (event: FillEvent<R>) => R;
You are viewing a condensed version of this merge commit. You can view the full changes here.