Skip to content

Commit

Permalink
Eslint: upgrade to version 8.0.0
Browse files Browse the repository at this point in the history
See:

- https://eslint.org/blog/2021/10/eslint-v8.0.0-released
- https://eslint.org/docs/user-guide/migrating-to-8.0.0

Known unresolved issues (with low impact )that we decided to accept:

- mysticatea/eslint-plugin-node#301

Known issues that need to be fixed first:

- [x] wait for import-js/eslint-plugin-import#2191 to be released and merged here
- [x] wait for gajus/eslint-plugin-flowtype#496 to be released and merged here
- [x] wait for testing-library/eslint-plugin-testing-library#462 to be released and merged here
- [ ] ~wait for mysticatea/eslint-plugin-node#294 to be released and merged here~ replaced (probably temporarily) with `eslint-plugin-n` which supports Eslint 8
- [x] wait for facebook/react#22248 to be released and merged here
- [x] release minor/patch version of Adeira Eslint Config before merging this breaking change
- [x] switch `NEXT_VERSION_ERROR` to `ERROR` (#3625)
  • Loading branch information
mrtnzlml committed Dec 24, 2021
1 parent 6f75e65 commit f6e5375
Show file tree
Hide file tree
Showing 7 changed files with 101 additions and 97 deletions.
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@
"@babel/eslint-parser": "^7.16.5",
"babel-jest": "^27.4.5",
"babel-loader": "^8.2.3",
"eslint": "^7.32.0",
"eslint": "^8.5.0",
"eslint-formatter-codeframe": "^7.32.1",
"flow-bin": "^0.168.0",
"glob": "^7.2.0",
"jest": "^27.4.5",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ class Bar {}
// Normally, Eslint would complain because of `consistent-return` error, however,
// rule `node/process-exit-as-throw` makes sure this is not the case.
// See: https://github.com/mysticatea/eslint-plugin-node/blob/master/docs/rules/process-exit-as-throw.md

// TODO: the following `consistent-return` error is incorrect and should be removed once the following
// issue is resolved: https://github.com/mysticatea/eslint-plugin-node/issues/301. We decided to
// accept the low risk for now to ease migration to Eslint 8.
// eslint-disable-next-line consistent-return
export function foo(a: boolean): ?Bar {
if (a) {
return new Bar();
Expand Down
2 changes: 1 addition & 1 deletion src/eslint-config-adeira/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,6 @@
"snapshot-diff": "^0.9.0"
},
"peerDependencies": {
"eslint": ">=7.24.0 <8.0.0"
"eslint": ">=8.0.0"
}
}
4 changes: 2 additions & 2 deletions src/eslint-fixtures-tester/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@
"@adeira/js": "^2.1.1",
"@babel/eslint-parser": "^7.16.5",
"@babel/runtime": "^7.16.5",
"eslint": "^7.32.0",
"eslint": "^8.5.0",
"jest-docblock": "^27.4.0"
},
"peerDependencies": {
"eslint": "^7.32.0"
"eslint": "^8.5.0"
}
}
2 changes: 1 addition & 1 deletion src/eslint-plugin-adeira/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"@adeira/eslint-fixtures-tester": "0.1.0",
"@adeira/flow-types-eslint": "0.0.0",
"@babel/eslint-parser": "^7.16.5",
"eslint": "^7.32.0"
"eslint": "^8.5.0"
},
"peerDependencies": {
"graphql": "^14.0.0 || ^15.0.0"
Expand Down
4 changes: 2 additions & 2 deletions src/eslint-plugin-sx/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,11 @@
"@adeira/flow-types-eslint": "0.0.0",
"@babel/code-frame": "^7.16.0",
"@babel/eslint-parser": "^7.16.5",
"eslint": "^7.32.0",
"eslint": "^8.5.0",
"react": "^17.0.2"
},
"peerDependencies": {
"@adeira/sx": "^0.28.0",
"eslint": "^7.32.0"
"eslint": "^8.5.0"
}
}
Loading

0 comments on commit f6e5375

Please sign in to comment.