Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix niceNum implementation #122

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

danmooney2
Copy link

@danmooney2 danmooney2 commented Oct 20, 2022

image

Description

Previous state hardcoded the thousands separators. I'm not sure which locale uses an apostrophe (') as a thousands separator but for the majority of the world that is not correct. Number.prototype.toLocaleString will format numbers based on user's locale.

Source: https://docs.oracle.com/cd/E19455-01/806-0169/overview-9/index.html

Related Issue

Motivation and Context

Readability

How Has This Been Tested?

Locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Previous state was not locale-dependent
js/script.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants