Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return error with the result code in parseResult #465

Open
wants to merge 4 commits into
base: stage
Choose a base branch
from
Open

Return error with the result code in parseResult #465

wants to merge 4 commits into from

Conversation

reugn
Copy link
Member

@reugn reugn commented Feb 19, 2025

No description provided.

@reugn reugn requested a review from khaf February 19, 2025 13:16
khaf
khaf requested changes Feb 21, 2025
View reviewed changes
Copy link
Collaborator

@khaf khaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could you please change the base to the stage branch? We usually merge everything there, test and then release into the main.

@reugn reugn changed the base branch from v8 to stage February 21, 2025 19:38
@reugn
Copy link
Member Author

reugn commented Feb 21, 2025

Changed the base branch to stage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khaf khaf khaf requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reugn @khaf