No need to update materials when scene fog changes

aframevr · Dec 19, 2023 · 20e19d0 · 20e19d0
1 parent 5b90b60
commit 20e19d0
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 17 deletions.
diff --git a/src/components/scene/fog.js b/src/components/scene/fog.js
@@ -30,7 +30,6 @@ module.exports.Component = register('fog', {
     // (Re)create fog if fog doesn't exist or fog type changed.
     if (!fog || data.type !== fog.name) {
       el.object3D.fog = getFog(data);
-      el.systems.material.updateMaterials();
       return;
     }
 
@@ -51,7 +50,6 @@ module.exports.Component = register('fog', {
     if (!fog) { return; }
 
     el.object3D.fog = null;
-    el.systems.material.updateMaterials();
   }
 });
 

diff --git a/src/systems/material.js b/src/systems/material.js
@@ -222,16 +222,6 @@ module.exports.System = registerSystem('material', {
       });
   },
 
-  /**
-   * Trigger update to all registered materials.
-   */
-  updateMaterials: function (material) {
-    var materials = this.materials;
-    Object.keys(materials).forEach(function (uuid) {
-      materials[uuid].needsUpdate = true;
-    });
-  },
-
   /**
    * Track textures used by material components, so that they can be safely
    * disposed when no longer in use. Textures must be registered here, and not

diff --git a/tests/components/scene/fog.test.js b/tests/components/scene/fog.test.js
@@ -8,7 +8,6 @@ suite('fog', function () {
     var self = this;
 
     el.addEventListener('loaded', function () {
-      self.updateMaterialsSpy = self.sinon.spy(el.systems.material, 'updateMaterials');
       // Stub scene load to avoid WebGL code.
       el.hasLoaded = true;
       el.setAttribute('fog', '');
@@ -28,10 +27,6 @@ suite('fog', function () {
       assert.ok(this.el.object3D.fog);
     });
 
-    test('triggers material update when adding fog', function () {
-      assert.ok(this.updateMaterialsSpy.called);
-    });
-
     test('updates fog', function () {
       var el = this.el;
       el.setAttribute('fog', 'color: #F0F');