Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fog removal from scene #5418

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Fix fog removal from scene #5418

merged 2 commits into from
Dec 19, 2023

Conversation

mrxz
Copy link
Contributor

@mrxz mrxz commented Dec 19, 2023

Description:
When removing the fog component, the fog wouldn't actually be removed but instead rendered "ineffective" by adjusting the near and far values. This however has two issues:

  • Fog type exponential doesn't use near and far meaning the fog would still be visible after removal
  • Shaders would still perform fog calculations for no reason

Changes proposed:

@dmarcos
Copy link
Member

dmarcos commented Dec 19, 2023

Thank you!

@dmarcos dmarcos merged commit 8e4f387 into aframevr:master Dec 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants