Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When removing the
fog
component, the fog wouldn't actually be removed but instead rendered "ineffective" by adjusting thenear
andfar
values. This however has two issues:exponential
doesn't usenear
andfar
meaning the fog would still be visible after removalChanges proposed:
null
(Three.js default value)updateMaterials()
method as it was only used by thefog
component and is not needed since WebGLRenderer: Add support for multiple programs per material. mrdoob/three.js#20135