Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAFF-28 remove optional label #1757

Merged
merged 3 commits into from
Sep 30, 2024
Merged

DAFF-28 remove optional label #1757

merged 3 commits into from
Sep 30, 2024

Conversation

adrian-yee
Copy link
Contributor

and add required vs optional reference

Provide an overview of your changes here. Include screenshots, photos or links if necessary.

View preview

Checklist

Preflight

  • Prefix the PR title with the slug of the package or component - e.g. accordion: Updated padding or docs: Updated header links
  • Describe the changes clearly in the PR description
  • Read and check your code before tagging someone for review
  • Create a changeset file by running yarn changeset. Learn more about change management.

Testing

  • Manually test component in various modern browsers at various sizes (use Browserstack)
  • Manually test component in various devices (phone, tablet, desktop)
  • Manually test component using a keyboard
  • Manually test component using a screen reader
  • Manually tested in dark mode
  • Component meets Web Content Accessibility Guidelines (WCAG) 2.1 standards
  • Add any necessary unit tests (HTML validation, snapshots etc)
  • Run yarn test to ensure tests are passing. If required, run yarn test -u to update any generated snapshots.

Documentation

  • Create or update documentation on the website
  • Create or update stories for Storybook
  • Create or update stories for Playroom snippets

Creating new component

  • Document the component for the website (docs/overview.mdx and docs/code.mdx at a minimum)
  • Preconstruct entrypoint has been created (run yarn in the root of the repo to do this)
  • Changeset file includes a minor
  • Export components for docs site and Playroom (docs/components/designSystemComponents.tsx)
  • Add component to Kitchen Sink (.storybook/stories/KitchenSink.tsx)
  • Add snippets to Playroom (docs/playroom/snippets.ts)
  • Add pictogram to Docs (docs/components/pictograms/index.tsx)

and add required vs optional reference
@adrian-yee adrian-yee self-assigned this Sep 5, 2024
Copy link

changeset-bot bot commented Sep 5, 2024

🦋 Changeset detected

Latest commit: f2a753e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ag.ds-next/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 5, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-09-30 06:37 UTC

@stowball stowball changed the base branch from main to develop September 12, 2024 04:56
Copy link

sonarcloud bot commented Sep 30, 2024

@ChrisLaneAU ChrisLaneAU merged commit a47676b into develop Sep 30, 2024
7 checks passed
@ChrisLaneAU ChrisLaneAU deleted the adrian-yee-patch-5 branch September 30, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants