DAFF-77 Password input Do's and Don'ts #1759

adrian-yee · 2024-09-05T02:49:33Z

Provide an overview of your changes here. Include screenshots, photos or links if necessary.

View preview

Checklist

Preflight

Prefix the PR title with the slug of the package or component - e.g. accordion: Updated padding or docs: Updated header links
Describe the changes clearly in the PR description
Read and check your code before tagging someone for review
Create a changeset file by running yarn changeset. Learn more about change management.

Testing

Manually test component in various modern browsers at various sizes (use Browserstack)
Manually test component in various devices (phone, tablet, desktop)
Manually test component using a keyboard
Manually test component using a screen reader
Manually tested in dark mode
Component meets Web Content Accessibility Guidelines (WCAG) 2.1 standards
Add any necessary unit tests (HTML validation, snapshots etc)
Run yarn test to ensure tests are passing. If required, run yarn test -u to update any generated snapshots.

Documentation

Create or update documentation on the website
Create or update stories for Storybook
Create or update stories for Playroom snippets

Creating new component

Document the component for the website (docs/overview.mdx and docs/code.mdx at a minimum)
Preconstruct entrypoint has been created (run yarn in the root of the repo to do this)
Changeset file includes a minor
Export components for docs site and Playroom (docs/components/designSystemComponents.tsx)
Add component to Kitchen Sink (.storybook/stories/KitchenSink.tsx)
Add snippets to Playroom (docs/playroom/snippets.ts)
Add pictogram to Docs (docs/components/pictograms/index.tsx)

changeset-bot · 2024-09-05T02:49:37Z

⚠️ No Changeset found

Latest commit: 9419f59

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR