Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Typo in exception name in storage/union.pyx #3208

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

sulan
Copy link
Contributor

@sulan sulan commented Aug 10, 2024

aimrocks.errors.RocksIOError instead of aimrocks.errorsRocksIOError

@CLAassistant
Copy link

CLAassistant commented Aug 10, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


sulan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@alberttorosyan alberttorosyan changed the title [fix] typo in exception name in storage/union.pyx [fix] Typo in exception name in storage/union.pyx Aug 12, 2024
Copy link
Member

@alberttorosyan alberttorosyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sulan! Thank you for this contribution 🙌
Could you please update the CHANGELOG.md file? Once done I'll merge this PR.

@alberttorosyan alberttorosyan merged commit 0db8bf8 into aimhubio:main Aug 13, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants