-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upstream header fixes #1301
upstream header fixes #1301
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1301 +/- ##
==========================================
- Coverage 89.84% 89.84% -0.01%
==========================================
Files 67 67
Lines 6087 6086 -1
==========================================
- Hits 5469 5468 -1
Misses 618 618
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
btw ran the local only tests as well and they passed |
hmm, perhaps we should try publishing a dev version of this for people to test with? |
Sounds reasonable, but I have no experience with it. Would you expect a significant amount of people to notice and participate? |
As expected, the arm64 job on Python 3.8 is still flaky, but since we marked it as experimental, that does not block the PR. You could merge it now, if you like. |
I'm thinking someone in that discussion group linked, had a post recently: #1300. Let me change this to a dev version instead then |
They could get the wheel from https://github.com/aio-libs/aiobotocore/actions/runs/13508980065 without us having to publish to PyPI. |
Thinking about it, I don't think our CI will work for a dev release. For starters, the CI trigger would not even fire: aiobotocore/.github/workflows/ci-cd.yml Line 11 in 7cb07f6
|
fixed (theoretically) |
fix to #1300