Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upstream header fixes #1301

Merged
merged 18 commits into from
Feb 25, 2025
Merged

upstream header fixes #1301

merged 18 commits into from
Feb 25, 2025

Conversation

thehesiod
Copy link
Collaborator

fix to #1300

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.84%. Comparing base (6437c89) to head (3f15b21).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1301      +/-   ##
==========================================
- Coverage   89.84%   89.84%   -0.01%     
==========================================
  Files          67       67              
  Lines        6087     6086       -1     
==========================================
- Hits         5469     5468       -1     
  Misses        618      618              
Flag Coverage Δ
unittests 89.84% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thehesiod
Copy link
Collaborator Author

btw ran the local only tests as well and they passed

jakob-keller
jakob-keller previously approved these changes Feb 24, 2025
@thehesiod
Copy link
Collaborator Author

hmm, perhaps we should try publishing a dev version of this for people to test with?

@jakob-keller
Copy link
Collaborator

hmm, perhaps we should try publishing a dev version of this for people to test with?

Sounds reasonable, but I have no experience with it. Would you expect a significant amount of people to notice and participate?

@jakob-keller
Copy link
Collaborator

As expected, the arm64 job on Python 3.8 is still flaky, but since we marked it as experimental, that does not block the PR. You could merge it now, if you like.

@thehesiod
Copy link
Collaborator Author

hmm, perhaps we should try publishing a dev version of this for people to test with?

Sounds reasonable, but I have no experience with it. Would you expect a significant amount of people to notice and participate?

I'm thinking someone in that discussion group linked, had a post recently: #1300. Let me change this to a dev version instead then

@jakob-keller
Copy link
Collaborator

jakob-keller commented Feb 24, 2025

I'm thinking someone in that discussion group linked, had a post recently: #1300. Let me change this to a dev version instead then

They could get the wheel from https://github.com/aio-libs/aiobotocore/actions/runs/13508980065 without us having to publish to PyPI.

@jakob-keller
Copy link
Collaborator

Let me change this to a dev version instead then

Thinking about it, I don't think our CI will work for a dev release. For starters, the CI trigger would not even fire:

[0-9]+.[0-9]+.[0-9]+

@thehesiod
Copy link
Collaborator Author

Let me change this to a dev version instead then

Thinking about it, I don't think our CI will work for a dev release. For starters, the CI trigger would not even fire:

[0-9]+.[0-9]+.[0-9]+

fixed (theoretically)

@thehesiod thehesiod added this pull request to the merge queue Feb 25, 2025
Merged via the queue into master with commit 3e55d33 Feb 25, 2025
20 checks passed
@thehesiod thehesiod deleted the thehesiod/aws-header-upstream-fix branch February 25, 2025 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants